Optionally enable Spinnaker feature flags #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpujadas can you take a quick look at what I added recently here: I'm trying to avoid having to add a values flag for all of the supported customizations. WDYT? |
|
I think that your approach with automated commands is well suited for:
In my opinion, enabling feature flags is easier to handle with a yaml list. Do you agree? |
|
Hey @dpujadas! I'm partially convinced although a lot of those features require significant out of band configuration to be useful (artifacts, chaos, and mine-canary). That said I think we should enable jobs by default for the chart. Can you make the change to default to jobs being enabled? |
|
'Jobs' enabled by default |
|
Thanks @dpujadas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a list of feature flags as explained in the docs (https://www.spinnaker.io/reference/halyard/commands/#hal-config-features-edit)